Skip to content

Remove workflow path filters for required checks#819

Open
hzxuzhonghu wants to merge 1 commit intovolcano-sh:mainfrom
hzxuzhonghu:required-check
Open

Remove workflow path filters for required checks#819
hzxuzhonghu wants to merge 1 commit intovolcano-sh:mainfrom
hzxuzhonghu:required-check

Conversation

@hzxuzhonghu
Copy link
Copy Markdown
Member

Summary

  • remove all paths and paths-ignore filters from CI workflows
  • keep existing branch and tag triggers unchanged
  • allow these workflows to run consistently so they can be configured as required checks

Testing

  • validated the edited workflow YAML files have no reported errors in VS Code
  • verified no remaining paths or paths-ignore filters exist under .github/workflows

Copilot AI review requested due to automatic review settings March 16, 2026 12:24
@gemini-code-assist
Copy link
Copy Markdown

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@volcano-sh-bot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from hzxuzhonghu. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hzxuzhonghu
Copy link
Copy Markdown
Member Author

The intention is to make ci jobs as required checks in github, otherwise the pr can be merged even job fails

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates GitHub Actions CI workflows to remove paths / paths-ignore filters so the workflows run consistently and can be configured as required checks on PRs.

Changes:

  • Removed all paths and paths-ignore filters from workflow triggers while keeping existing branch/tag trigger patterns.
  • Minor YAML formatting normalization in a few workflows (quotes/whitespace), without changing job logic.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
.github/workflows/python-tests.yml Removes path filtering so Python tests run for all PRs/pushes to main.
.github/workflows/python-lint.yml Removes path filtering so Python lint runs for all PRs/pushes on configured branches.
.github/workflows/python-licenses-lint.yml Removes path filtering; minor formatting change for python-version.
.github/workflows/licenses-lint.yaml Removes paths-ignore so license lint runs for all PRs to matching branches.
.github/workflows/go-tests.yml Removes path filtering; minor formatting change for go-version-file.
.github/workflows/go-check.yml Removes paths-ignore so Go checks run for all PRs/pushes to main.
.github/workflows/e2e-tests.yml Removes path filtering; minor formatting change for go-version-file.
.github/workflows/docs-tests.yml Removes path filtering; normalizes quoting in setup-node inputs.
.github/workflows/build-push-release.yml Removes path filtering from tag/PR triggers; minor YAML formatting normalization (needs, version quoting, whitespace).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants