Skip to content

fix Jobs tab namespace selection#167

Open
GautamBytes wants to merge 1 commit intovolcano-sh:mainfrom
GautamBytes:fix-namespace-selection-dropdown
Open

fix Jobs tab namespace selection#167
GautamBytes wants to merge 1 commit intovolcano-sh:mainfrom
GautamBytes:fix-namespace-selection-dropdown

Conversation

@GautamBytes
Copy link
Copy Markdown

Addresses #159

  • Changed default namespace filter from "default" to "All", and only send ?namespace= when a specific namespace is chosen.

  • Updated header to show a “Filter” button next to Namespace, Queue, and Status, injecting "All" at the top of each menu.

  • Now the Namespace dropdown opens correctly and lists “All” plus every namespace.

@volcano-sh-bot
Copy link
Copy Markdown
Contributor

Welcome @GautamBytes!

It looks like this is your first PR to volcano-sh/dashboard.

Thank you, and welcome to Volcano. 😃

@volcano-sh-bot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign monokaix
You can assign the PR to them by writing /assign @monokaix in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@GautamBytes
Copy link
Copy Markdown
Author

/assign @Monokaix

@danielhuntleyalpine
Copy link
Copy Markdown

Hello, I just wanted to check the status of this and see if there have been any updates, or if there’s anything I can do to help move it along. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants