Add custom action type to volume policies#9540
Draft
sseago wants to merge 2 commits intovmware-tanzu:mainfrom
Draft
Add custom action type to volume policies#9540sseago wants to merge 2 commits intovmware-tanzu:mainfrom
sseago wants to merge 2 commits intovmware-tanzu:mainfrom
Conversation
dd9dd22 to
accd26e
Compare
kaovilai
reviewed
Feb 11, 2026
Comment on lines
+330
to
+334
| pv, err = kubeutil.GetPVForPVC(pvc, v.client) | ||
| if err != nil { | ||
| v.logger.WithError(err).Errorf("fail to get PV for PVC %s", pvc.Namespace+"/"+pvc.Name) | ||
| return false, err | ||
| } |
Collaborator
There was a problem hiding this comment.
Will check later if this is ok. There's some areas that this need to not error for the new pending/lost PVC volume policy feature
Signed-off-by: Scott Seago <[email protected]>
accd26e to
b6dafe8
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #9540 +/- ##
==========================================
- Coverage 60.60% 60.50% -0.10%
==========================================
Files 386 387 +1
Lines 36389 36589 +200
==========================================
+ Hits 22054 22140 +86
- Misses 12758 12861 +103
- Partials 1577 1588 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Tiger Kaovilai <[email protected]> Signed-off-by: Scott Seago <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Velero!
Please add a summary of your change
This adds a new volume policy action type "custom", intended to be used by external plugins which handle PVCs.
Does your change fix a particular issue?
Fixes #9505
Please indicate you've done the following:
make new-changelog) or comment/kind changelog-not-requiredon this PR.site/content/docs/main.