KAAP-797 Remove client secret from byoh onboard command#906
Closed
srm6867 wants to merge 86 commits intovmware-tanzu:mainfrom
Closed
KAAP-797 Remove client secret from byoh onboard command#906srm6867 wants to merge 86 commits intovmware-tanzu:mainfrom
srm6867 wants to merge 86 commits intovmware-tanzu:mainfrom
Conversation
- bundled repo for 1.26 kube - Sample yamls for byoh config with service account - Webhook fix to allow sevice account user - Fix to avoid same secret name for install & bootstrap
…izable, More specific logging to file
… kubeconfig at only one place
This reverts commit 8db3384.
Webhook and naming conflict fix in BYOH
* Added chart-generator * Added Byoh-chart * increased cpu and memory limit * removed unnecessary fields from kustomization.yaml , changed comparision of userName and managerServiceAccount in byohost_webhook controller , changed cpu memory range , changed path in kustomizeconfig.yaml * reverted kustomization.yaml * changes added to pr * reverted kustomization.yaml * Added byoh and tested * added validation for string len check byohost_webhook.go * reverted changes of webhook * changes in chart-generator.sh * removed allowance of req v1.update * added substrs len check --------- Co-authored-by: Snehal Shelke <[email protected]>
…deb (#5) --------- Co-authored-by: snslk <[email protected]> Co-authored-by: Snehal Shelke <[email protected]>
* k8s bundle --------- Co-authored-by: Snehal Shelke <[email protected]>
…stants for kubeconfig
…-image-build-script add build script for controller manager
…sioning Added versioning for byohctl
…#28) Co-authored-by: Vaibhav Dubewar <[email protected]>
Co-authored-by: Vaibhav Dubewar <[email protected]>
Co-authored-by: Vaibhav Dubewar <[email protected]>
…lector Listing only hosts from same NS to attach
#32) * kaap-553: Proceed with host cleanup in case of decommission even if byohost doesn't exist in mgmt plane * consolidated func to perform cleanup when machineRef is unset --------- Co-authored-by: Vaibhav Dubewar <[email protected]>
KAAP-537 : BYOH enhancements (Updated flags to be consistent with cloudctl, interactive password input)
…etion of byohost object when byoMachine does not exists in the cluster (#34) Co-authored-by: Vaibhav Dubewar <[email protected]>
Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.17.0 to 0.35.0. - [Commits](golang/crypto@v0.17.0...v0.35.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-version: 0.35.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ost objects (#37) * Allowing users of type <name>@<domain>.<tld> to patch byohost objects * Added unit test for the same * Deny request from unauthorized-user --------- Co-authored-by: Vaibhav Dubewar <[email protected]>
… cluster deletion (#38) Co-authored-by: Vaibhav Dubewar <[email protected]>
This reverts commit 47cd654. Co-authored-by: Vaibhav Dubewar <[email protected]>
…e while deauth/decom (#50)
Not removing cluster-name label in the case of upgrade
* KAAP-541:Changed CRD of byoclusteer to show status * KAAP-541:Changed version of controller-gen and added lines for additional columns in byocluster.yaml --------- Co-authored-by: Harsh Srivastava <[email protected]> Co-authored-by: Harsh Srivastava <[email protected]>
* KAAP-541:Changed CRD of byoclusteer to show status * KAAP-541:Changed version of controller-gen and added lines for additional columns in byocluster.yaml * KAAP-513:Added the Uninstallation secret in the controllers and apis * added logging in k8sinstaller config * changed in uninstallation secret creation * KAAP-513:addition of status update of installation and uninstallation data --------- Co-authored-by: Harsh Srivastava <[email protected]> Co-authored-by: Harsh Srivastava <[email protected]>
…ing default as service (#64) * KAAP-548: Changes in cmd to remove tenant from required flag * KAAP-548: Changes in onboard_test.go to match the flags of onboard.go * KAAP-548: Changes in onboard_test.go to fix the unit tests * KAAP-548: Necessary refactoring of the code to remove duplicacy --------- Co-authored-by: Harsh Srivastava <[email protected]>
…le for onboarding node in byohctl (#67) * Resolve stash conflict in onboard.go and continue work * KAAP-483: Added the functioality for input values from config file and also added unit tests * KAAP-483: Changes in the functionality of config file * KAAP-483: Removal of dead code --------- Co-authored-by: Harsh Srivastava <[email protected]>
* Version Bump: Updated version of ubuntu from 20.04 to 22.04 * Fixing the versions of go in action files * changes in golangci yml * changes for the lint issues * changes in .golangci.yaml * changes in .golangci.yaml * changes for e2e and tests fail --------- Co-authored-by: Harsh Srivastava <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Additional information
Special notes for your reviewer