Private/main/jayanth/add tc build dependency#901
Closed
jayanth-tjvrr wants to merge 15 commits intovmware-tanzu:mainfrom
Closed
Private/main/jayanth/add tc build dependency#901jayanth-tjvrr wants to merge 15 commits intovmware-tanzu:mainfrom
jayanth-tjvrr wants to merge 15 commits intovmware-tanzu:mainfrom
Conversation
- bundled repo for 1.26 kube - Sample yamls for byoh config with service account - Webhook fix to allow sevice account user - Fix to avoid same secret name for install & bootstrap
This reverts commit 8db3384.
Webhook and naming conflict fix in BYOH
* Added chart-generator * Added Byoh-chart * increased cpu and memory limit * removed unnecessary fields from kustomization.yaml , changed comparision of userName and managerServiceAccount in byohost_webhook controller , changed cpu memory range , changed path in kustomizeconfig.yaml * reverted kustomization.yaml * changes added to pr * reverted kustomization.yaml * Added byoh and tested * added validation for string len check byohost_webhook.go * reverted changes of webhook * changes in chart-generator.sh * removed allowance of req v1.update * added substrs len check --------- Co-authored-by: Snehal Shelke <snehalshelke@pf9s-MacBook-Air-3.local>
…deb (#5) --------- Co-authored-by: snslk <snehal@C02VN0ZCHV2D.local> Co-authored-by: Snehal Shelke <snehalshelke@pf9s-MacBook-Air-3.local>
* k8s bundle --------- Co-authored-by: Snehal Shelke <snehalshelke@pf9s-MacBook-Air-3.local>
…-image-build-script add build script for controller manager
…Error Fixed CREATE/UPDATE function in webhook configuration of BYOH
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reads the
byohImagevalue from TC build dependency using kustomize patch.Testing:
Built an capi chart with the edited byoh-chart from this private branch and upgraded an existing setup.
We see that the patch is being applied:
and the image is getting reflected in byoh-controller-pod: