Fix for bundle version in the installer CLI#449
Fix for bundle version in the installer CLI#449georgievaVMW wants to merge 1 commit intovmware-tanzu:mainfrom
Conversation
Made a map from k8s filter to k8s bundle (this is in order to easily output correct bundle for example 1.23.* -> 1.22) Made changes to installer.go and the registry tests to accomodate the added second argument to the function.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #449 +/- ##
==========================================
- Coverage 68.40% 68.39% -0.01%
==========================================
Files 23 23
Lines 1728 1734 +6
==========================================
+ Hits 1182 1186 +4
- Misses 474 476 +2
Partials 72 72
🚀 New features to boost your workflow:
|
|
A note on why we switched from filter array to filter map. Initially the installer was meant to use a simple container (array) to hold the filters and that was the right choice at the time. We discussed different solutions like stripping the filter masks (the dot asterisk part) from the string of the help of the CLI, as well as extracting the map to separate module which could be shared between modules (CLI and Installer). |
Made small changes so the CLI shows correct bundle version.
Made a map from k8s filter to k8s bundle (this is in order to easily output correct bundle for example 1.23.* -> 1.22)
Made changes to installer.go and the registry tests to accommodate the added second argument to the function.