[ROCm][CI] Update GSM8K eval config to use fp8-and-mixed models list (MI355)#37721
Merged
DarkLight1337 merged 1 commit intovllm-project:mainfrom Mar 21, 2026
Merged
Conversation
…(MI355) Signed-off-by: Andreas Karatzas <[email protected]>
AndreasKaratzas
added
the
ready
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates a configuration file for the AMD CI pipeline. Specifically, it changes the model list used for the GSM8K correctness evaluation from models-mi3xx-fp8.txt to models-mi3xx-fp8-and-mixed.txt. This change is intended to fix a CI failure. The modification is straightforward and I did not find any issues of high or critical severity.
Collaborator
Author
|
Test group confirmed green: https://buildkite.com/vllm/amd-ci/builds/6750/steps/canvas?sid=019d0d76-eb93-45c1-b29a-3419241e5278&tab=output |
DarkLight1337
approved these changes
Mar 21, 2026
JartX
pushed a commit
to JartX/vllm
that referenced
this pull request
Mar 21, 2026
…(MI355) (vllm-project#37721) Signed-off-by: sagformas <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up for:
Updated the GSM8K correctness eval in the AMD CI pipeline to use the
models-mi3xx-fp8-and-mixed.txtconfig list instead ofmodels-mi3xx-fp8.txt. Addresses failure inmi355_2: LM Eval Small Models (B200-MI325)Motivation: https://buildkite.com/vllm/amd-ci/builds/6721/steps/canvas?sid=019d09d4-713e-4e07-bcb9-9b38689611a0&tab=output
cc @kenroche