Skip to content

[main] Upgrade the Golang version to go1.25.7#19306

Open
vitess-bot wants to merge 1 commit intomainfrom
upgrade-go-to-1.25.7-on-main
Open

[main] Upgrade the Golang version to go1.25.7#19306
vitess-bot wants to merge 1 commit intomainfrom
upgrade-go-to-1.25.7-on-main

Conversation

@vitess-bot
Copy link
Contributor

@vitess-bot vitess-bot commented Feb 5, 2026

This Pull Request bumps the Golang version to go1.25.7 and the bootstrap version to 52.

Do not trust the bot blindly. A thorough code review must be done to ensure all the files have been correctly modified.

cc @vitessio/release

@vitess-bot vitess-bot added the Benchmark me Add label to PR to run benchmarks label Feb 5, 2026
@vitess-bot vitess-bot requested a review from mattlord as a code owner February 5, 2026 18:16
@vitess-bot vitess-bot added the Component: General Changes throughout the code base label Feb 5, 2026
@vitess-bot vitess-bot requested a review from frouioui as a code owner February 5, 2026 18:16
@vitess-bot vitess-bot added go Skip CI Skip CI actions from running labels Feb 5, 2026
@vitess-bot vitess-bot requested a review from a team February 5, 2026 18:16
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Feb 5, 2026

Hello! 👋

This Pull Request is now handled by arewefastyet. The current HEAD and future commits will be benchmarked.

You can find the performance comparison on the arewefastyet website.

@github-actions github-actions bot added this to the v24.0.0 milestone Feb 5, 2026
@vitess-bot vitess-bot bot added NeedsWebsiteDocsUpdate What it says NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Feb 5, 2026
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Feb 5, 2026

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@mhamza15 mhamza15 removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says Skip CI Skip CI actions from running NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Feb 5, 2026
@codecov
Copy link

codecov bot commented Feb 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.94%. Comparing base (b004c09) to head (58369fe).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19306      +/-   ##
==========================================
- Coverage   69.95%   69.94%   -0.01%     
==========================================
  Files        1610     1610              
  Lines      216056   216056              
==========================================
- Hits       151133   151131       -2     
- Misses      64923    64925       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vitess-bot vitess-bot force-pushed the upgrade-go-to-1.25.7-on-main branch from cfb8afa to a2ece6d Compare February 6, 2026 00:43
@vitess-bot vitess-bot added the Skip CI Skip CI actions from running label Feb 6, 2026
@mhamza15 mhamza15 removed the Skip CI Skip CI actions from running label Feb 6, 2026
@vitess-bot vitess-bot force-pushed the upgrade-go-to-1.25.7-on-main branch from 9b98b48 to e6f5b8c Compare February 7, 2026 00:43
@timvaillancourt timvaillancourt requested review from timvaillancourt and removed request for timvaillancourt February 8, 2026 00:03
@timvaillancourt
Copy link
Contributor

Weird. My review is requested but it won't let me add one 🤔

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@vitess-bot vitess-bot force-pushed the upgrade-go-to-1.25.7-on-main branch from 42563ad to 58369fe Compare February 8, 2026 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Benchmark me Add label to PR to run benchmarks Component: Docker Component: General Changes throughout the code base go Type: CI/Build Type: Dependencies Dependency updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants