Merged
Conversation
Contributor
Author
|
@akueisara |
akueisara
reviewed
Jan 28, 2025
Contributor
akueisara
left a comment
akueisara
left a comment
There was a problem hiding this comment.
Sorry, this might have been a mistake in the legacy code. Could you ensure that each class has the minimum visibility outside the library?
Additionally, could you update CHANGELOG.md?
sampleAppKotlin/src/main/java/com/virtusize/sampleappkotlin/WebAppActivity.kt
Outdated
Show resolved
Hide resolved
virtusize-auth/src/main/java/com/virtusize/android/auth/data/FacebookUser.kt
Outdated
Show resolved
Hide resolved
virtusize-auth/src/main/java/com/virtusize/android/auth/repositories/GoogleRepository.kt
Outdated
Show resolved
Hide resolved
virtusize-auth/src/main/java/com/virtusize/android/auth/utils/VirtusizeUriHelper.kt
Outdated
Show resolved
Hide resolved
virtusize-auth/src/main/java/com/virtusize/android/auth/views/VirtusizeAuthAppActivity.kt
Outdated
Show resolved
Hide resolved
virtusize-auth/src/main/java/com/virtusize/android/auth/views/VitrusizeAuthActivity.kt
Outdated
Show resolved
Hide resolved
- make auth-specific classes with internal - clean up gradle settings a bit
Contributor
Author
|
@akueisara updated CHANGELOG and marked |
akueisara
approved these changes
Feb 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
⬅️ As Is
virtrusize-authis a separate repository that complicates it's support and release➡️ To Be
virtusize-authis a part of main SDK repository now☑️ Checklist
Log.detc are removedproduction