fix(cert-manager): use DNS-01 challenges, instead of HTTP-01 challenges
#80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sid-maddy
requested review from
Robin5605,
import-pandas-as-numpy and
jonathan-d-zhang
sid-maddy
force-pushed
the
sid/bugfix/letsencrypt-solvers
branch
from
9ecf434 to
6309d8d
Compare
| spec: | ||
| acme: | ||
| email: [email protected] | ||
| email: [email protected] |
There was a problem hiding this comment.
I don't even know if this email is live, but we need to rehost our email provider. Blocked for now; let me figure out a solution for this.
sid-maddy
force-pushed
the
sid/bugfix/letsencrypt-solvers
branch
from
6309d8d to
34bb46a
Compare
sid-maddy
force-pushed
the
sid/bugfix/letsencrypt-solvers
branch
from
34bb46a to
08651df
Compare
sid-maddy
requested review from
a team
and removed request for
Robin5605 and
jonathan-d-zhang
sid-maddy
force-pushed
the
sid/bugfix/letsencrypt-solvers
branch
2 times, most recently
from
4525506 to
9062fbe
Compare
…lenges Signed-off-by: Siddhesh Mhadnak <[email protected]>
Also, removed the `.spec.acme.solvers[*].dns01.cloudflare.email`, since, ```bash kubectl explain --api-version=cert-manager.io/v1 ClusterIssuer.spec.acme.solvers.dns01.cloudflare.email # Email of the account, only required when using API key based authentication. ``` and we're using API token based authentication.
sid-maddy
force-pushed
the
sid/bugfix/letsencrypt-solvers
branch
from
9062fbe to
52711d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: https://marcolenzo.eu/how-to-integrate-cert-manager-with-lets-encrypt-and-cloudflare/#:~:text=why%20is%20the%20http-01%20ingress%20solver%20incompatible%3F