Update axi_master.v#1
Open
jhjs7 wants to merge 1 commit into
Open
Conversation
the maximum value of wlen_count can be 14 which is in binary 001110 where 5th bit is always 0 but you are assigning 5th bit of wlen_count to wlast where C_WLEN_COUNT_WIDTH is 6. so, it will be 5th bit of wlen_count but it can never go to 16 where we can get 5th bit as 1 as we are down counting (OR) decrementing wlen_count
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the maximum value of wlen_count can be 14 which is in binary 001110 where 5th bit is always 0 but you are assigning 5th bit of wlen_count to wlast where C_WLEN_COUNT_WIDTH is 6. so, it will be 5th bit of wlen_count but it can never go to 16 where we can get 5th bit as 1 as we are down counting (OR) decrementing wlen_count