Add support for reading inheritors from a phpstan-sealed tag#11818
Open
Add support for reading inheritors from a phpstan-sealed tag#11818
Conversation
This improves interoperability for vendor libraries that are using phpstan. The `@phpstan-sealed` tag has the same semantic than `@psalm-inheritors`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This improves interoperability for vendor libraries that are using phpstan. The
@phpstan-sealedtag has the same semantic than@psalm-inheritors.Closes #11510
Note
Medium Risk
Updates docblock parsing to alias
@phpstan-sealedinto the inheritors constraint logic, which can change class/interface inheritance validation outcomes for existing codebases.Overview
Adds interoperability with PHPStan’s
@phpstan-sealedby mapping it to Psalm’s@psalm-inheritorsduring docblock parsing (viacombined_tags).Updates
ClassLikeDocblockParserto read inheritors only fromcombined_tags, and extends the test suite to assert that extending a@phpstan-sealedbase class triggersInheritorViolationthe same way@psalm-inheritorsdoes.Reviewed by Cursor Bugbot for commit fd4ae22. Bugbot is set up for automated code reviews on this repo. Configure here.