Add max_depth option to unserialize() callmap type#11702
Open
eyupcanakman wants to merge 1 commit intovimeo:6.xfrom
Open
Add max_depth option to unserialize() callmap type#11702eyupcanakman wants to merge 1 commit intovimeo:6.xfrom
eyupcanakman wants to merge 1 commit intovimeo:6.xfrom
Conversation
PHP 7.4 added max_depth as an option to unserialize(), but Psalm's callmap only declared allowed_classes in the array shape, causing a false-positive InvalidArgument error. Add max_depth?: int to the options type, version-gated to PHP 7.4+ via CallMap_74_delta.php. Add regression tests for both valid usage and invalid type detection. Fix vimeo#11295
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #11295
PHP 7.4 added
max_depthas an option tounserialize(), but Psalm's callmap only declaredallowed_classesin the array shape -- causing a false-positiveInvalidArgumenterror.This PR adds
max_depth?: intto the options type, version-gated to PHP 7.4+ via a new entry inCallMap_74_delta.php.https://www.php.net/manual/en/function.unserialize.php