Conversation
kkmuffme
changed the title
…precision" PHP Deprecated notices
kkmuffme
force-pushed
the
php-81-float-int-deprecated-warning
branch
from
5916c41 to
bb44ef1
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix various PHP 8.x "Implicit conversion from float ... to int loses precision" PHP Deprecated notices
Perhaps error reporting in CI should include E_DEPRECATED?
No new tests added, since I actually encountered this by running the existing tests for the fixed code - however due to error reporting excluding E_DEPRECATED this was ignored