Fix alter ignoring MissingThrowsDocblock suppression

[d-mitrofanov-v]

Psalter ignored MissingThrowsDocblock suppression in config and changed suppressed files anyway.
This happened because the check for isSuppressed was missing in if statement for $codebase->alter_code and because check for alter_code was not inside if (!$is_expected) block

---

Note

Medium Risk
Changes the conditions under which Psalm’s code-alteration path inserts @throws annotations, which can affect automated file rewrites during psalter runs. Risk is moderate because it alters auto-fix behavior but is scoped to the MissingThrowsDocblock fix flow.

Overview
Fixes psalter’s MissingThrowsDocblock auto-fix so it does not modify code when the issue is suppressed. The analyzer now creates a reusable MissingThrowsDocblock issue instance, passes suppression info into IssueBuffer::maybeAdd, and only calls FunctionDocblockManipulator::addThrowsDocblock() when alter_code is enabled, the issue is configured to be fixed, and the specific instance is not suppressed.

Also includes a minor whitespace-only adjustment around the MissingOverrideAttribute auto-fix block.

^{Reviewed by Cursor Bugbot for commit 95034c7. Bugbot is set up for automated code reviews on this repo. Configure here.}

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Reviewed by Cursor Bugbot for commit c102fb1. Configure here.}

[cursor]

Suppressed exceptions included in altered throws docblock

Medium Severity

The $missingThrowsDocblockErrors array accumulates ALL non-expected exception names unconditionally (before the suppression check), but addThrowsDocblock passes this full array when any non-suppressed exception triggers the alter path. If exception A is suppressed and exception B is not, processing B will call addThrowsDocblock([A, B]), adding suppressed exception A to the @throws docblock. The suppression check gates whether addThrowsDocblock is called, but doesn't filter the array contents.

 

^{Reviewed by Cursor Bugbot for commit c102fb1. Configure here.}