Update setParent to accept string parameter and use as ID selector#80
Open
tiagor87 wants to merge 4 commits intovictorb:masterfrom
Open
Update setParent to accept string parameter and use as ID selector#80tiagor87 wants to merge 4 commits intovictorb:masterfrom
tiagor87 wants to merge 4 commits intovictorb:masterfrom
Conversation
|
👍 I would very much like this pulled into master and released. Having to call document to get element in the controller makes one more item I have to stub in unit tests. :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update method setParent to accept ID string as parameter. That way, There is no need to get element in the controller.
Sorry for the indentation, WebStorm updated automatically.