Added Hash Map Implementation for java#593
Open
bhaweshgit06 wants to merge 1 commit intovichitr:masterfrom
Open
Added Hash Map Implementation for java#593bhaweshgit06 wants to merge 1 commit intovichitr:masterfrom
bhaweshgit06 wants to merge 1 commit intovichitr:masterfrom
Conversation
sharindanic
reviewed
Dec 19, 2025
sharindanic
left a comment
sharindanic
left a comment
There was a problem hiding this comment.
Thanks for the contribution! ,I left a couple of inline comments around edge cases (negative hash index and remove handling). Overall, nice work 👍
|
|
||
| private int HashCode(K key) { | ||
| int hc = key.hashCode(); | ||
| int bucketIndex = hc % numBucket; |
There was a problem hiding this comment.
Bucket index can become negative:
In HashCode(), hc % numBucket may return a negative value if hashCode() is negative, which can cause buckets.get(bucketIndex) to crash.
Suggestion: use Math.floorMod(hc, numBucket) for a safe non-negative index.
Comment on lines
+43
to
+44
| if (head.key.equals(key)) { | ||
| head.value = value; |
There was a problem hiding this comment.
Potential NPE and return value issue in removeKey():
- If the bucket is empty,
headcan be null, sohead.key.equals(key)would throw an exception.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.