fix(mermaid): add data-streamdown, aria-modal, and correct role to fullscreen overlay#508
Open
sleitor wants to merge 1 commit intovercel:mainfrom
Open
fix(mermaid): add data-streamdown, aria-modal, and correct role to fullscreen overlay#508sleitor wants to merge 1 commit intovercel:mainfrom
sleitor wants to merge 1 commit intovercel:mainfrom
Conversation
…llscreen overlay
- Add data-streamdown="mermaid-fullscreen" for stable CSS targeting
- Change role="button" to role="dialog" (correct semantics for a modal overlay)
- Add aria-modal="true" for screen readers
- Add aria-label for accessible name
- Remove tabIndex={0} (not needed on dialog element)
- Update biome-ignore comment to match table fullscreen pattern
Closes vercel#506
Contributor
|
@sleitor is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
data-streamdown="mermaid-fullscreen"for stable CSS targetingrole="button"torole="dialog"(correct semantics for a modal overlay)aria-modal="true"for screen readersaria-labelfor accessible nametabIndex={0}(not needed on dialog element)Closes #506