feat: Add limited support for objectPosition property on images#464
Draft
damianstasik wants to merge 1 commit intovercel:mainfrom
Draft
feat: Add limited support for objectPosition property on images#464damianstasik wants to merge 1 commit intovercel:mainfrom
damianstasik wants to merge 1 commit intovercel:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
damianstasik
changed the title
shuding
reviewed
Apr 30, 2023
Member
shuding
left a comment
shuding
left a comment
There was a problem hiding this comment.
Yep please use snapshots so it's easier to identify changes. We might modify the underlying SVG code some day. Thanks!
|
Can we get some movement on this? This is definitely functionality that I'd like to use! |
Author
|
I'll try to take a look at it today or tomorrow. |
damianstasik
force-pushed
the
limited-support-of-object-position
branch
from
a762517 to
940de75
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently any image that has
objectFitproperty will be centered without any way to control this behavior.This PR adds a limited support for
objectPositionfor images, by tweaking what is being passed topreserveAspectRatioproperty.By limited I mean you need to pass both X and Y, and for both of them you can pass only three keyword values:
It is still something more than always center, so I hope it is useful enough to get merged.
I am marking this as draft, because I am not sure what is the preferred way of testing it. Should I convert the test cases to use snapshots?