Skip to content

fix(vm/console): fix VNC reconnection causing focus loss#9727

Open
pierre-briffaux wants to merge 1 commit intomasterfrom
fix-vm-console-refresh
Open

fix(vm/console): fix VNC reconnection causing focus loss#9727
pierre-briffaux wants to merge 1 commit intomasterfrom
fix-vm-console-refresh

Conversation

@pierre-briffaux
Copy link
Copy Markdown
Contributor

Description

VM console was periodically interrupting user input due to unnecessary VNC reconnections triggered by background VM data refreshes.

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

Review process

If you are an external contributor, you can skip this part. Simply create the pull request, and we'll get back to you as soon as possible.

This 2-passes review process aims to:

  • develop skills of junior reviewers
  • limit the workload for senior reviewers
  • limit the number of unnecessary changes by the author
  1. The author creates a PR.
  2. Review process:
    1. The author assigns the junior reviewer.
    2. The junior reviewer conducts their review:
      • Resolves their comments if they are addressed.
      • Adds comments if necessary or approves the PR.
    3. The junior reviewer assigns the senior reviewer.
    4. The senior reviewer conducts their review:
      • If there are no unresolved comments on the PR → merge.
      • Otherwise, we continue with 3.
  3. The author responds to comments and/or makes corrections, and we go back to 2.

Notes:

  1. The author can request a review at any time, even if the PR is still a Draft.
  2. In theory, there should not be more than one reviewer at a time.
  3. The author should not make any changes:
    • When a reviewer is assigned.
    • Between the junior and senior reviews.

@pierre-briffaux pierre-briffaux self-assigned this Apr 15, 2026
Signed-off-by: Pierre Briffaux <pierre.briffaux@vates.tech>
@pierre-briffaux pierre-briffaux force-pushed the fix-vm-console-refresh branch from 11796f6 to 4aca9c7 Compare April 15, 2026 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant