Skip to content

chore(xo-stack): update Vite, Typescript and Vue related libs#9703

Draft
OlivierFL wants to merge 3 commits intomasterfrom
xo6/update-dependencies
Draft

chore(xo-stack): update Vite, Typescript and Vue related libs#9703
OlivierFL wants to merge 3 commits intomasterfrom
xo6/update-dependencies

Conversation

@OlivierFL
Copy link
Copy Markdown
Collaborator

@OlivierFL OlivierFL commented Apr 13, 2026

Description

Update Vite, TypeScript and Vue-related dependencies

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

Review process

If you are an external contributor, you can skip this part. Simply create the pull request, and we'll get back to you as soon as possible.

This 2-passes review process aims to:

  • develop skills of junior reviewers
  • limit the workload for senior reviewers
  • limit the number of unnecessary changes by the author
  1. The author creates a PR.
  2. Review process:
    1. The author assigns the junior reviewer.
    2. The junior reviewer conducts their review:
      • Resolves their comments if they are addressed.
      • Adds comments if necessary or approves the PR.
    3. The junior reviewer assigns the senior reviewer.
    4. The senior reviewer conducts their review:
      • If there are no unresolved comments on the PR → merge.
      • Otherwise, we continue with 3.
  3. The author responds to comments and/or makes corrections, and we go back to 2.

Notes:

  1. The author can request a review at any time, even if the PR is still a Draft.
  2. In theory, there should not be more than one reviewer at a time.
  3. The author should not make any changes:
    • When a reviewer is assigned.
    • Between the junior and senior reviews.

@OlivierFL OlivierFL self-assigned this Apr 13, 2026
@OlivierFL OlivierFL force-pushed the xo6/update-dependencies branch 2 times, most recently from e6822db to e5bfe80 Compare April 13, 2026 09:57
@OlivierFL OlivierFL requested a review from pdonias April 14, 2026 09:19
pdonias
pdonias requested changes Apr 16, 2026
View reviewed changes
Comment thread .github/workflows/ci.yml Outdated
uses: actions/setup-node@v4
with:
node-version: '22.3'
node-version: '>=22.3'
Copy link
Copy Markdown
Member

@pdonias pdonias Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, we should probably use >=22.12 so that it both matches the requirement for --experimental-test-module-mocks (22.3) and Vite's requirement (22.12).

Comment thread @xen-orchestra/lite/src/libs/story/story-param.ts
function WithType(Base: MixinAbstractConstructor<BaseParam>) {
abstract class WithType extends Base /* implements HasType */ {
#type: string | undefined
_type: string | undefined
Copy link
Copy Markdown
Member

@pdonias pdonias Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you removing the private fields? Is there an issue with TypeScript?

Copy link
Copy Markdown
Collaborator Author

@OlivierFL OlivierFL Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, with the type-check:
image
Even when typing private _type the error is still there.

Comment thread @xen-orchestra/lite/vite.config.ts Outdated
Copy link
Copy Markdown
Member

@pdonias pdonias Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the migration guide, rollupOptions was renamed rolldownOptions.

Comment thread @xen-orchestra/lite/vite.config.ts Outdated
Comment on lines 95 to 97
Copy link
Copy Markdown
Member

@pdonias pdonias Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still from the migration guide, commonjsOptions is ignored now.

Comment thread @xen-orchestra/web/vite.config.ts Outdated
Comment on lines 42 to 46
Copy link
Copy Markdown
Member

@pdonias pdonias Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as XO Lite's config: we should be able to remove this entirely.

@OlivierFL OlivierFL force-pushed the xo6/update-dependencies branch 2 times, most recently from 5995ca6 to 240b59d Compare April 22, 2026 15:14
@OlivierFL
feedback: rename Vite config properties from rollupOptions to rolldow…
22b972b 
…nOptions, and remove deprecated commonjsOptions
@OlivierFL OlivierFL force-pushed the xo6/update-dependencies branch from 240b59d to 22b972b Compare April 22, 2026 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pdonias pdonias pdonias requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@OlivierFL OlivierFL

Labels

XO Lite XO Web Core XO Web 6

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@OlivierFL @pdonias