Skip to content

Fix funds forwarder#2468

Merged
jmoreira-valory merged 2 commits intomainfrom
fix/funds_forwarder
Apr 13, 2026
Merged

Fix funds forwarder#2468
jmoreira-valory merged 2 commits intomainfrom
fix/funds_forwarder

Conversation

@jmoreira-valory
Copy link
Copy Markdown
Collaborator

Proposed changes

Fix funds forwarder

Fixes

Add missing chain_id

Types of changes

What types of changes does your code introduce? (A breaking change is a fix or feature that would cause existing functionality and APIs to not work as expected.)
Put an x in the box that applies

  • Non-breaking fix (non-breaking change which fixes an issue)
  • Breaking fix (breaking change which fixes an issue)
  • Non-breaking feature (non-breaking change which adds functionality)
  • Breaking feature (breaking change which adds functionality)
  • Refactor (non-breaking change which changes implementation)
  • Messy (mixture of the above - requires explanation!)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • I am making a pull request against the main branch (left side). Also you should start your branch off our main.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have locally run AI agents that could be impacted and they do not present failures derived from my changes
  • Public-facing documentation has been updated with the changes affected by this PR. Even if the provided contents are not in their final form, all significant information must be included.
  • Any backwards-incompatible/breaking change has been clearly documented in the upgrading document.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.55%. Comparing base (6d66479) to head (566554c).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2468   +/-   ##
=======================================
  Coverage   92.55%   92.55%           
=======================================
  Files         243      243           
  Lines       17259    17261    +2     
=======================================
+ Hits        15974    15976    +2     
  Misses       1285     1285           
Flag Coverage Δ
unittests 92.55% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jmoreira-valory jmoreira-valory merged commit 537d76b into main Apr 13, 2026
39 of 40 checks passed
@jmoreira-valory jmoreira-valory deleted the fix/funds_forwarder branch April 14, 2026 14:30
@DhairyaPatel7 DhairyaPatel7 mentioned this pull request Apr 16, 2026
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants