fix(java): update inflight_requests_limit test for async Rust rejection#5658
Merged
avifenesh merged 1 commit intorelease-2.2from Mar 25, 2026
Merged
fix(java): update inflight_requests_limit test for async Rust rejection#5658avifenesh merged 1 commit intorelease-2.2from
avifenesh merged 1 commit intorelease-2.2from
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
avifenesh
force-pushed
the
fix/inflight-test-async-rejection
branch
from
f7a2107 to
bd50b80
Compare
avifenesh
force-pushed
the
fix/inflight-test-async-rejection
branch
from
bd50b80 to
88b3ac5
Compare
avifenesh
force-pushed
the
fix/inflight-test-async-rejection
branch
from
88b3ac5 to
f3e5cd4
Compare
With Java's inflight counter removed (PR #5656), rejection now happens asynchronously in Rust's send_command() rather than synchronously in Java's AsyncRegistry. The tokio task ordering is non-deterministic, so any of the N+1 requests may be the one rejected — not necessarily the last one sent. Update the test to wait for async processing and count rejected requests instead of asserting specific request ordering. Signed-off-by: Avi Fenesh <[email protected]>
avifenesh
force-pushed
the
fix/inflight-test-async-rejection
branch
from
f3e5cd4 to
c31b6b5
Compare
shohamazon
approved these changes
Mar 25, 2026
avifenesh
added a commit
that referenced
this pull request
Mar 25, 2026
… rejection (#5658)" This reverts commit 9331bf4. Signed-off-by: Avi Fenesh <[email protected]>
avifenesh
added a commit
that referenced
this pull request
Mar 25, 2026
* Revert "fix(java): update inflight_requests_limit test for async Rust rejection (#5658)" This reverts commit 9331bf4. Signed-off-by: Avi Fenesh <[email protected]> * Revert "fix(java): remove Java-side inflight counter, let Rust be sole authority (#5656)" This reverts commit 072ccdf. Signed-off-by: Avi Fenesh <[email protected]> --------- Signed-off-by: Avi Fenesh <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #5656. With Java's inflight counter removed, rejection happens asynchronously in Rust's
send_command()rather than synchronously in Java'sAsyncRegistry.The
inflight_requests_limitintegration test assumed synchronous rejection (the N+1th request is always the one rejected). With async Rust rejection, tokio task ordering is non-deterministic — any request may be rejected.Fix: Wait for async processing, then count rejected requests instead of asserting specific ordering.
1 file changed, test-only.