fix(python,java,node,rust): add missing vector search 1.1 args by edlng · Pull Request #5550 · valkey-io/valkey-glide

edlng · 2026-03-09T18:11:37Z

Summary

In Valkey Search 1.1, some arguments were missed in FT.SEARCH such as DIALECT and NOCONTENT. This PR adds it and fixes the response handling in the core.

Issue link

Closes #5626

Features / Behaviour Changes

DIALECT
NOCONTENT

Implementation

New args added for each language, response handling changed in the core

Limitations

Testing

New test cases have been added.

Checklist

Before submitting the PR make sure the following are checked:

This Pull Request is related to one issue.
Commit message has a detailed description of what changed and why.
Tests are added or updated.
CHANGELOG.md and documentation files are updated.
Linters have been run (make *-lint targets) and Prettier has been run (make prettier-fix).
Destination branch is correct - main or release
Create merge commit if merging release branch into main, squash otherwise.

Signed-off-by: Edward Liang <edward.liang@improving.com>

xShinnRyuu · 2026-03-23T22:12:29Z

python/tests/async_tests/tests_server_modules/test_ft.py

+        )
+        assert await glide_client.hset(key1, {vec_field: vector1}) == 1
+        assert await glide_client.hset(key2, {vec_field: vector2}) == 1
+        time.sleep(self.sleep_wait_time)


We probably shouldnt be using time.sleep() for an async test

I noticed that it was also a recurring pattern in the existing tests of this file. Should we replace them all?

xShinnRyuu · 2026-03-23T22:13:05Z

python/tests/async_tests/tests_server_modules/test_ft.py

+            == OK
+        )
+        assert await glide_client.hset(key1, {vec_field: vector1}) == 1
+        time.sleep(self.sleep_wait_time)


similar here probably should not use time.sleep() which will blocking the thread

see comment above

Aryex · 2026-03-23T21:30:13Z

java/integTest/src/test/java/glide/modules/VectorSearchTests.java

Could you check the formatting for this file? The spacing seems weird.

Talked with Kiro about it, but apparently it follows the Google Java Style convention. Running spotless checks also pass. I do agree formatting might be a bit weird but I think a lot of the existing Java files follow this convention so fixing it might be a project-wide task 😵‍💫

Aryex · 2026-03-23T21:48:24Z

java/integTest/src/test/java/glide/modules/VectorSearchTests.java


+    @SneakyThrows
+    @Test
+    public void ft_search_nocontent() {


So from what I gathered, this test is doing:

Insert 2 vectors into test db

Search for them with NOCONTENT set.

assert that the return value is correct.

The additional vector syntax make this test feels complicated for me. Since the focus is to check nocontent was applied, could we just use a simple set and get test with nocontent and assert the response?

I think we should keep this test as is. The issue with NOCONTENT was that it had to change the way the response was converted in core. IMO, probably better to leave it like this to verify the parsing and everything isn't broken.

java/integTest/src/test/java/glide/modules/VectorSearchTests.java

Aryex · 2026-03-23T22:25:16Z

java/integTest/src/test/java/glide/modules/VectorSearchTests.java

+
+        FTSearchOptions options =
+                FTSearchOptions.builder()
+                        .dialect(2)


Since only dialect 2 is supported, what is expected to happen if dialect 1 is specified?

An error is thrown DIALECT requires a non negative integer >=2 and <= 4

Signed-off-by: Edward Liang <edward.liang@improving.com>

edlng requested a review from a team as a code owner March 9, 2026 18:11

edlng had a problem deploying to AWS_ACTIONS March 9, 2026 18:11 — with GitHub Actions Error

edlng had a problem deploying to AWS_ACTIONS March 9, 2026 18:11 — with GitHub Actions Failure

edlng temporarily deployed to AWS_ACTIONS March 9, 2026 18:11 — with GitHub Actions Inactive

edlng had a problem deploying to AWS_ACTIONS March 9, 2026 18:11 — with GitHub Actions Failure

edlng marked this pull request as draft March 9, 2026 18:12

edlng force-pushed the edlng/vss-1.1-missing-args branch from aa2d96f to 77481b6 Compare March 10, 2026 16:00

edlng had a problem deploying to AWS_ACTIONS March 10, 2026 16:00 — with GitHub Actions Error

edlng mentioned this pull request Mar 11, 2026

feat(python, java, node): Add Valkey Search 1.2 arguments to FT.* commands #5571

Draft

7 tasks

edlng force-pushed the edlng/vss-1.1-missing-args branch from 77481b6 to 42f6616 Compare March 11, 2026 22:19

edlng had a problem deploying to AWS_ACTIONS March 11, 2026 22:19 — with GitHub Actions Error

edlng force-pushed the edlng/vss-1.1-missing-args branch from 42f6616 to 605f21a Compare March 23, 2026 21:52

edlng had a problem deploying to AWS_ACTIONS March 23, 2026 21:52 — with GitHub Actions Error

edlng marked this pull request as ready for review March 23, 2026 21:53

fix(python,java,node,rust): add missing vector search 1.1 args

ceec41f

Signed-off-by: Edward Liang <edward.liang@improving.com>

edlng force-pushed the edlng/vss-1.1-missing-args branch from 605f21a to ceec41f Compare March 23, 2026 21:55

edlng had a problem deploying to AWS_ACTIONS March 23, 2026 21:55 — with GitHub Actions Error

edlng had a problem deploying to AWS_ACTIONS March 23, 2026 21:57 — with GitHub Actions Error

xShinnRyuu reviewed Mar 23, 2026

View reviewed changes

xShinnRyuu requested a review from Aryex March 23, 2026 22:15

Aryex reviewed Mar 23, 2026

View reviewed changes

address comment

faf1989

Signed-off-by: Edward Liang <edward.liang@improving.com>

edlng requested a deployment to AWS_ACTIONS March 24, 2026 18:14 — with GitHub Actions Waiting

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(python,java,node,rust): add missing vector search 1.1 args#5550

fix(python,java,node,rust): add missing vector search 1.1 args#5550
edlng wants to merge 2 commits intomainfrom
edlng/vss-1.1-missing-args

edlng commented Mar 9, 2026 •

edited

Loading

Uh oh!

xShinnRyuu Mar 23, 2026 •

edited

Loading

Uh oh!

edlng Mar 24, 2026

Uh oh!

xShinnRyuu Mar 23, 2026

Uh oh!

edlng Mar 24, 2026

Uh oh!

Aryex Mar 23, 2026

Uh oh!

edlng Mar 24, 2026

Uh oh!

Aryex Mar 23, 2026 •

edited

Loading

Uh oh!

edlng Mar 24, 2026

Uh oh!

Uh oh!

Aryex Mar 23, 2026

Uh oh!

edlng Mar 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

edlng commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Issue link

Features / Behaviour Changes

Implementation

Limitations

Testing

Checklist

Uh oh!

xShinnRyuu Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Aryex Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

edlng commented Mar 9, 2026 •

edited

Loading

xShinnRyuu Mar 23, 2026 •

edited

Loading

Aryex Mar 23, 2026 •

edited

Loading