Introduce rd.saltboot namespace, mark rest as deprecated#177
Draft
Introduce rd.saltboot namespace, mark rest as deprecated#177
Conversation
This commit introduces new rd.saltboot cmdline namespace: String values: MASTER => rd.saltboot.master MINION_ID_PREFIX => rd.saltboot.id_prefix SALT_TIMEOUT => rd.saltboot.timeout SALT_STOP_TIMEOUT => rd.saltboot.stop_timout salt_device => rd.saltboot.device Boolean values, now only set if true: DISABLE_UNIQUE_SUFFIX => rd.saltboot.nosuffix DISABLE_HOSTNAME_ID => rd.saltboot.nohostname DISABLE_ID_PREFIX => rd.saltboot.noprefix USE_FQDN_MINION_ID => rd.saltboot.usefqdn USE_MAC_MINION_ID => rd.saltboot.usemac kiwidebug => rd.saltboot.debug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces new rd.saltboot cmdline namespace:
String values:
MASTER => rd.saltboot.master
MINION_ID_PREFIX => rd.saltboot.id_prefix
SALT_TIMEOUT => rd.saltboot.timeout
SALT_STOP_TIMEOUT => rd.saltboot.stop_timout
salt_device => rd.saltboot.device
Boolean values, now only set if true:
DISABLE_UNIQUE_SUFFIX => rd.saltboot.nosuffix
DISABLE_HOSTNAME_ID => rd.saltboot.nohostname
DISABLE_ID_PREFIX => rd.saltboot.noprefix
USE_FQDN_MINION_ID => rd.saltboot.usefqdn
USE_MAC_MINION_ID => rd.saltboot.usemac
kiwidebug => rd.saltboot.debug
Important change is also booleans values are now set only if true on the command line. i.e. kiwidebug=0 on the command line now means kiwidebug variable is not set at all.
This PR also fixes shellcheck reported warnings and style issues.