Remove SPV_codeplay_usm_generic_storage_class. #1004
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvdijk
force-pushed
the
remove-SPV_codeplay_usm_generic_storage_class
branch
from
f642703 to
79b0886
Compare
coldav
approved these changes
Sep 23, 2025
The SPV_codeplay_usm_generic_storage_class SPIR-V was only ever used by ComputeCpp, which is no longer available. There is no longer a reason for us to handle it, so remove it.
hvdijk
force-pushed
the
remove-SPV_codeplay_usm_generic_storage_class
branch
from
79b0886 to
e0dd5b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Remove SPV_codeplay_usm_generic_storage_class.
Reason for change
The SPV_codeplay_usm_generic_storage_class SPIR-V was only ever used by ComputeCpp, which is no longer available. There is no longer a reason for us to handle it.
Description of change
Remove it.
Anything else we should know?
If there's any other relevant information we should know that may help us in
understanding and verifying your patch, please include it here.
Checklist