Streamline the test for reserving slots in constrained arena#2016
Draft
aleksei-fedotov wants to merge 2 commits intomasterfrom
Draft
Streamline the test for reserving slots in constrained arena#2016aleksei-fedotov wants to merge 2 commits intomasterfrom
aleksei-fedotov wants to merge 2 commits intomasterfrom
Conversation
13 tasks
dnmokhov
reviewed
Mar 18, 2026
| int max_num_external_threads = std::min(ta_concurrency, reserved_slots); | ||
| int num_tasks = ta_concurrency - int(workers_cannot_fully_occupy_arena); | ||
| const int max_num_external_threads = actual_reserved_slots; | ||
| const int num_tasks = ta_concurrency; // One task per each arena slot |
Contributor
There was a problem hiding this comment.
Doesn't cgroups prevent the extra thread when actual_reserved_slots is 0?
Suggested change
| const int num_tasks = ta_concurrency; // One task per each arena slot | |
| const int num_tasks = max_num_workers + max_num_external_threads; // One task per each arena slot |
aleksei-fedotov
force-pushed
the
fix-create_numa_task_arenas-test
branch
from
7ef0553 to
ce658c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test is a bit confusing because of the various conditions here and there to which the test tries to adapt. This change is an attempt to simplify the test in terms of readability and comprehension.