Use dladdr to keep libtbbmalloc loaded on POSIX#1849
Open
emilazy wants to merge 1 commit intouxlfoundation:masterfrom
Open
Use dladdr to keep libtbbmalloc loaded on POSIX#1849emilazy wants to merge 1 commit intouxlfoundation:masterfrom
dladdr to keep libtbbmalloc loaded on POSIX#1849emilazy wants to merge 1 commit intouxlfoundation:masterfrom
Conversation
39475a0 to
6cf190a
Compare
Author
|
It seems like |
Author
|
Looks like this is (nondeterministically?) causing problems on Linux, and I don’t know why :( My guesses (e.g. needs |
This fixes issues that arise when `libtbbmalloc` cannot be loaded by relative path, makes the behaviour consistent with the Windows code path, and eliminates the duplication of `MALLOCLIB_NAME`.
6cf190a to
791d42d
Compare
Author
|
I guess this was the same thing as: oneTBB/src/tbb/dynamic_link.cpp Lines 382 to 391 in 91af3ae Switching to a private function fixed it. Let me know if you want to add an |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes issues that arise when
libtbbmalloccannot be loaded by relative path, makes the behaviour consistent with the Windows code path, and eliminates the duplication ofMALLOCLIB_NAME.Fixes # - issue number(s) if exists
Type of change
Choose one or multiple, leave empty if none of the other choices apply
Add a respective label(s) to PR if you have permissions
Tests
Probably too difficult to test. I confirmed that this stops the test suite crashing on program exit on macOS in Nixpkgs, though.
Documentation
Breaks backward compatibility
Notify the following users
List users with
@to send notificationsOther information