Feature/beam energy by danielegelhoff13 · Pull Request #92 · uw-loci/EBEAM_dashboard

danielegelhoff13 · 2026-03-13T17:52:44Z

Description

This PR introduces the Beam Energy subsystem for the EBEAM Dashboard, including the new Beam Energy subpanel UI, Modbus communication with the Knob Box, and logging of errors in the Knob Box operation.

Beam Energy Subpanel

During Operation

Not Connected to Knob Box

Scope of Changes Made

UI: Beam Energy dashboard panel, beam_energy.py

Voltage and current displays, indicator lights, and switch states reflect the Knob Box state of operation.
Communication status indicators verify if connection is functioning.

Modbus Communication: knob_box_modbus.py

Modbus register reads of the 4 Monitoring Arduinos in the Knob Box.
Each unit is polled in order with 3 possible read attempts per unit.
Connection attempts to the Knob Box are controlled by exponentially backing off to avoid slowing down the Dashboard.
COM ports are configured for the Knob Box to Dashboard connection.

dashboard.py and main.py were modified to create the Beam Energy subsystem and Knob Box instrument control objects.

Tests Run

A full Knob Box BTest was run to test both the hardware and software functionality together and is documented here:

https://docs.google.com/document/d/1PGchj_ZEUTGBbvStswzUiM31VCPpr_ZamW7ts0TJBkY/edit?tab=t.0#heading=h.g681r5xzzqq7

With corresponding images from the test here:

https://docs.google.com/presentation/d/1L03H2zA92JuW7442mnP7uVDj44vJ63D-VFfa9U56O-w/edit?slide=id.g2b5328b7f44_0_0#slide=id.g2b5328b7f44_0_0

bwalkerMIR · 2026-03-24T20:36:15Z

@danielegelhoff13 what is the status of this PR and branch?

bwalkerMIR · 2026-03-24T20:40:10Z

@chott24 has made changes to the firmware that need to be updated in this branch. @BaiTian6641 is going to branch off this feature/beam-energy branch to try to incorporate Chase's changes and get this tested and working in parallel. Ideally please work together on this. If one branch is shown to work and be tested and ready for a PR we will use that one and either merge the other or discard.

Chase said: FYI the modbus frames have been completely redone. I'll update the dev spec with a more thorough description once I've got the code done.

For now, this README is up to date for the firmware changes (as of 2026-03-24)
https://github.com/uw-loci/knob-box/tree/bugfix/latch-modbus-flag-registers/monitor-arduino#modbus-register-map

danielegelhoff13 · 2026-04-07T21:14:05Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cd636d2eaa

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-04-07T21:18:11Z

+                elif subsystem_name == 'Beam Energy':
+                    subsystem.update_com_ports(new_com_ports)


Invoke Beam Energy COM-port updater

The new Beam Energy branch is currently unreachable because it sits under if hasattr(subsystem, 'update_com_port'), but BeamEnergySubsystem defines update_com_ports (plural) instead. In practice, changing the KnobBox port from the config UI will not reconfigure Beam Energy, so it keeps using the stale serial port until restart. Please either check for update_com_ports here or move the Beam Energy case outside this guard.

Useful? React with 👍 / 👎.

Fixed with commit 36051ba.

Note: this issue needs further attention for other subsystems. See Asana task: https://app.asana.com/1/492353873344076/project/1208196184307227/task/1213974761625776?focus=true

chatgpt-codex-connector · 2026-04-07T21:18:11Z

+        return self.ps_connected
+
+    def handle_disconnect(self, msg=''):
+        self.log(f"Disconnect: {msg}", err=True)


Pass a supported argument to log()

handle_disconnect calls self.log(..., err=True), but log only accepts (message, level). If a disconnect occurs, this raises TypeError before the disconnect cleanup runs, so the serial handle/state reset path is skipped exactly when it is needed most. Use a LogLevel value (for example LogLevel.ERROR) instead of the unsupported err kwarg.

Useful? React with 👍 / 👎.

This is an error in glassman.py, which should have been deleted before codex reviewed the PR. The most recent commit 1b27b5d deletes glassman.py and knob_box.py, which are both unused, old serial drivers.

danielegelhoff13 · 2026-04-08T16:09:00Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1b27b5d603

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

danielegelhoff13 · 2026-04-08T17:05:36Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e26d330f3f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

danielegelhoff13 · 2026-04-08T17:26:26Z

@codex review

chatgpt-codex-connector · 2026-04-08T17:26:35Z

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7ae4e5d8ab

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

bwalkerMIR · 2026-04-09T17:30:18Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 91b8f72afd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

danielegelhoff13 · 2026-04-09T18:07:28Z

Commit e703087 fixes another reconnection behavior bug (found by Codex):

Problem: Backoff is checked in initialize_knob_box_modbus (_next_connect_time), but reconnect workers are still spawned frequently (every poll/update cycle), then immediately return when backoff hasn’t elapsed. That causes repeated thread creation and scheduling churn even during intentional backoff windows.

Why it matters: This can still create unnecessary CPU/thread overhead and queue pressure during outages—the same failure mode this series intends to reduce.

Fix: Check backoff time remaining before creating a reconnection worker thread.

danielegelhoff13 · 2026-04-09T20:22:43Z

@bwalkerMIR could you ask codex to do another review when you get a chance?

bwalkerMIR · 2026-04-10T02:30:32Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: be3a4341ef

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

danielegelhoff13 · 2026-04-14T14:27:27Z

@bwalkerMIR This PR is ready for review and merge.

Co-authored-by: sbasu107 <[email protected]>

…menu

…merging PR #101)

…ignal edges that do not consititue an error (e.g. Arm Beams signal).

… Knob box uses the modbus driver.

…now is cleared if after() schedling fails.

…on is called from both close() AND update_com_ports() paths.

…y conection attempt to avoid losing backoff data and spamming log with connection attempts.

… the 3kV enable switch will now be logged correctly.

…time to expire to spawn. Previously, they would spawn then immediately return very frequently, not respecting backoff.

…eduling a reconnection attempt. Deasserts controller's connected field when polling error.

… message when all these attempts fail in a row.

bwalkerMIR · 2026-04-30T21:49:46Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c68c66562e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

…ead. Co-authored-by: Copilot <[email protected]>

…M_dashboard into feature/beam-energy

bwalkerMIR · 2026-05-01T21:27:08Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f8d5608b32

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

bwalkerMIR

This is a much needed addition of the Knob Box / Beam Energy subsystem into the dashboard and the code looks good. Codex has reviewed many times and @danielegelhoff13 has patched anything worth patching so far, and we have been left with P2 or lower priority issues. The code has been well tested by @chott24 and @danielegelhoff13 in

https://docs.google.com/document/d/1PGchj_ZEUTGBbvStswzUiM31VCPpr_ZamW7ts0TJBkY/edit?tab=t.0#heading=h.g681r5xzzqq7

With corresponding images from the test here:

https://docs.google.com/presentation/d/1L03H2zA92JuW7442mnP7uVDj44vJ63D-VFfa9U56O-w/edit?slide=id.g2b5328b7f44_0_0#slide=id.g2b5328b7f44_0_0

Approved.

bwalkerMIR added the Knob Box label Mar 24, 2026

chatgpt-codex-connector Bot reviewed Apr 7, 2026

View reviewed changes

chatgpt-codex-connector Bot reviewed Apr 8, 2026

View reviewed changes

Comment thread subsystem/beam_energy/beam_energy.py Outdated

Comment thread instrumentctl/knob_box/pymodbus_tester.py Outdated

chatgpt-codex-connector Bot reviewed Apr 8, 2026

View reviewed changes

Comment thread subsystem/beam_energy/beam_energy.py

Comment thread subsystem/beam_energy/beam_energy.py Outdated

danielegelhoff13 marked this pull request as ready for review April 8, 2026 17:29

chatgpt-codex-connector Bot reviewed Apr 8, 2026

View reviewed changes

Comment thread subsystem/beam_energy/beam_energy.py Outdated

Comment thread subsystem/beam_energy/beam_energy.py

uw-loci deleted a comment from chatgpt-codex-connector Bot Apr 9, 2026

chatgpt-codex-connector Bot reviewed Apr 9, 2026

View reviewed changes

Comment thread subsystem/beam_energy/beam_energy.py

Comment thread instrumentctl/knob_box/knob_box_modbus.py Outdated

chatgpt-codex-connector Bot reviewed Apr 10, 2026

View reviewed changes

Comment thread subsystem/beam_energy/beam_energy.py

Comment thread subsystem/beam_energy/beam_energy.py

uw-loci deleted a comment from chatgpt-codex-connector Bot Apr 14, 2026

danielegelhoff13 assigned chott24 Apr 16, 2026

Copilot AI pushed a commit that referenced this pull request Apr 28, 2026

Merge PR #92 feature/beam-energy into integration branch

568badc

Co-authored-by: sbasu107 <[email protected]>

sbasu107 and others added 5 commits April 30, 2026 13:01

First draft of Knob Box UI for dashboard

366715a

Changes to scale and font style

4d81db4

Created skeleton for knob box modbus mimicking E5CN_modbus

538c9ed

Integrating drivers with Beam Energy Subsystem

100f001

Added dropdown menus for beam energy and glassman to com port config …

ead3242

…menu

danielegelhoff13 added 19 commits April 30, 2026 13:01

Reduced connection timeouts again (commit c176840 was overwritten by …

a1d189b

…merging PR #101)

Added INFO level logging for whenever a switch on KnobBox is flipped.

916ab26

ERROR logging for flags, reset/forced off signals. INFO logging for s…

c591960

…ignal edges that do not consititue an error (e.g. Arm Beams signal).

Logging is working and has been tested.

aa4f1f1

Invoke Beam Energy COM port update method.

dc26d45

Deleted unused incomplete serial drivers glassman.py and knob_box.py.…

36a661f

… Knob box uses the modbus driver.

Fixed possble "stays disconnected" error. reconnect_in_progress flag …

e4b1e6a

…now is cleared if after() schedling fails.

Improved the test script for usability.

a91b533

Polling thread is stopped inside close_com_ports, because this functi…

cb8ce94

…on is called from both close() AND update_com_ports() paths.

All logging now uses the helper inside this class.

9143ddf

Use one single controller instance instead of re-creating one on ever…

5d555bd

…y conection attempt to avoid losing backoff data and spamming log with connection attempts.

Remove update to 3kV enable switch state before checking for edge, so…

910ad54

… the 3kV enable switch will now be logged correctly.

Worker threads for reconnecting to the knob box now wait for backoff …

f43c109

…time to expire to spawn. Previously, they would spawn then immediately return very frequently, not respecting backoff.

Removed unused variable from tester file.

bc5c12d

Fixes possible state when KB controller is "connected" but we are sch…

aa8b1e8

…eduling a reconnection attempt. Deasserts controller's connected field when polling error.

Add BeamEnergySubsystem to public API.

c21ecfc

Fixed worker thread modifying Tkinter object issue.

9a49dc8

Increased maximum read attempts for responsiveness, and log one clear…

3283307

… message when all these attempts fail in a row.

Beam Energy README (written by Codex)

5002a77

danielegelhoff13 force-pushed the feature/beam-energy branch from 155c12e to 5002a77 Compare April 30, 2026 20:24

Merge branch 'develop' into feature/beam-energy

c68c665

chatgpt-codex-connector Bot reviewed Apr 30, 2026

View reviewed changes

Comment thread subsystem/beam_energy/beam_energy.py

danielegelhoff13 and others added 2 commits April 30, 2026 17:25

Logging is thread-safe, using a queue that is flushed by the main thr…

c510a38

…ead. Co-authored-by: Copilot <[email protected]>

Merge branch 'feature/beam-energy' of https://github.com/uw-loci/EBEA…

f8d5608

…M_dashboard into feature/beam-energy

chatgpt-codex-connector Bot reviewed May 1, 2026

View reviewed changes

Comment thread subsystem/beam_energy/beam_energy.py

Comment thread subsystem/beam_energy/beam_energy.py

bwalkerMIR approved these changes May 1, 2026

View reviewed changes

bwalkerMIR merged commit 88dc9db into develop May 1, 2026
1 check passed

bwalkerMIR deleted the feature/beam-energy branch May 1, 2026 23:23

		elif subsystem_name == 'Beam Energy':
		subsystem.update_com_ports(new_com_ports)

Conversation

danielegelhoff13 commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Beam Energy Subpanel

Scope of Changes Made

Tests Run

Uh oh!

bwalkerMIR commented Mar 24, 2026

Uh oh!

bwalkerMIR commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

danielegelhoff13 commented Apr 7, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

danielegelhoff13 Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

danielegelhoff13 Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

danielegelhoff13 commented Apr 8, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

danielegelhoff13 commented Apr 8, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

danielegelhoff13 commented Apr 8, 2026

Uh oh!

chatgpt-codex-connector Bot commented Apr 8, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

bwalkerMIR commented Apr 9, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

danielegelhoff13 commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

danielegelhoff13 commented Apr 9, 2026

Uh oh!

bwalkerMIR commented Apr 10, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

danielegelhoff13 commented Apr 14, 2026

Uh oh!

danielegelhoff13 commented Mar 13, 2026 •

edited

Loading

bwalkerMIR commented Mar 24, 2026 •

edited

Loading

danielegelhoff13 commented Apr 9, 2026 •

edited

Loading