Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions src/uu/stty/src/stty.rs
Original file line number Diff line number Diff line change
Expand Up @@ -530,9 +530,15 @@ fn parse_saved_state(arg: &str) -> Option<Vec<u32>> {
// Validate all parts are non-empty valid hex
let mut values = Vec::with_capacity(expected_parts);
for (i, part) in parts.iter().enumerate() {
// `from_str_radix` doesn't document its behavior for this case,
// thus, we do this to guarantee stability
if part.is_empty() {
return None; // GNU rejects empty hex values
}
// TO-DO: avoid `from_str_radix`
if part.as_bytes()[0] == b'+' {
return None;
}
let val = u32::from_str_radix(part, 16).ok()?;

// Control characters (indices 4+) must fit in u8
Expand Down Expand Up @@ -1422,6 +1428,18 @@ mod tests {
assert_eq!(parse_rows_cols("65537"), Some(1)); // wraps to 1
}

#[test]
fn test_sane_parse_saved_state() {
let result = parse_saved_state("00:01:ff:7f");
assert_eq!(&result, Some(&[0, 1, 255, 127]));
}

#[test]
fn test_parse_saved_state_no_plus() {
let result = parse_saved_state("+00:+01:+ff:+7f");
assert_eq!(&result, None);
}

// Sane control character defaults
#[test]
fn test_get_sane_control_char_values() {
Expand Down
Loading