tee: dedup code by static dispatch macro#12076
Closed
oech3 wants to merge 1 commit intouutils:mainfrom
Closed
Conversation
|
GNU testsuite comparison: |
Contributor
|
This may be a bit more idiomatic than the macro approach: impl Writer {
fn as_write(&mut self) -> &mut dyn Write {
match self {
Writer::File(f) => f,
Writer::Stdout(s) => s,
}
}
} |
Contributor
Author
|
|
Contributor
Author
|
I would just move previous code to uucore. |
Contributor
impl Writer {
fn with_write<T>(&mut self, f: impl FnOnce(&mut dyn Write) -> T) -> T {
match self {
Writer::File(w) => f(w),
Writer::Stdout(w) => f(w),
}
}
}Could quality is equivalent: https://rust.godbolt.org/z/f5bMhYfTY |
Contributor
Author
|
Is the optimization guaranteed for all Rust version and targets? |
Contributor
|
Can't use |
Contributor
Author
|
Hesitating to add new dep. |
Contributor
Yeah, I think the duplication would be fine there |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.