ls: check ACL using full path, not bare filename#11812
Draft
sylvestre wants to merge 2 commits intouutils:mainfrom
Draft
ls: check ACL using full path, not bare filename#11812sylvestre wants to merge 2 commits intouutils:mainfrom
sylvestre wants to merge 2 commits intouutils:mainfrom
Conversation
When measuring column widths for the long listing, `has_acl` was called with `item.display_name()` (the bare filename) instead of `item.path()`. Listing a directory from a different cwd meant the ACL lookups ran against the wrong directory, failed, and the `+` marker column was never reserved — producing output like `-rw-r--r--+1` with no separator before the link count.
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #11789