Skip to content

Conversation

@aaron-ang
Copy link
Contributor

Fix CI failure due to newer clippy version in CI.

@aaron-ang aaron-ang changed the title fix: clippy unnecessary unwrap fix(CI): clippy unnecessary unwrap Jan 22, 2026
@github-actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 22, 2026

Merging this PR will degrade performance by 5.36%

⚡ 3 improved benchmarks
❌ 3 regressed benchmarks
✅ 136 untouched benchmarks
⏩ 180 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation seq_custom_separator 28.7 ms 30.1 ms -4.81%
Simulation seq_integers 26.1 ms 27.6 ms -5.25%
Simulation seq_with_step 13.3 ms 14.1 ms -5.36%
Simulation unexpand_large_file[10] 592.4 ms 553.5 ms +7.02%
Simulation unexpand_many_lines[100000] 282.6 ms 264 ms +7.02%
Simulation mv_multiple_to_dir 12.9 ms 12.4 ms +4.1%

Comparing aaron-ang:clippy-hotfix (df04d02) with main (2de0a5b)

Open in CodSpeed

Footnotes

  1. 180 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@github-actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/shuf/shuf-reservoir (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/sort/sort-stale-thread-mem (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)

@cakebaker cakebaker merged commit d2bd2d3 into uutils:main Jan 22, 2026
129 of 131 checks passed
@cakebaker
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants