feat: add support for 'hyphenated' format in the serde module#865
Merged
KodrAus merged 1 commit intouuid-rs:mainfrom Mar 13, 2026
Merged
feat: add support for 'hyphenated' format in the serde module#865KodrAus merged 1 commit intouuid-rs:mainfrom
KodrAus merged 1 commit intouuid-rs:mainfrom
Conversation
KodrAus
reviewed
Mar 7, 2026
Member
KodrAus
left a comment
There was a problem hiding this comment.
Thanks for working on this @FrenchDilettante! This change looks good to me. The only issue I spotted in the docs is also present in all the other serde modules. It's not something you've introduced. Clearly we need to do some more work in this area of the codebase to clean it up 🙂
This module would have been originally missing because the default text format is hyphenated, but introducing a dedicated module for it makes sense because that module forces binary-based formats to still use hyphenated strings, and rejects non hyphenated formats.
KodrAus
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi folks, this is my first PR against this project, so if I'm doing anything wrong, by all means please let me know and I'll update it 🙏
While using the
serdefeature, I noticed that it lacks support for the hyphenated format:Looking at the code, I found out that the format is supported by the library, just missing from the serde feature itself. There was an issue documenting that gap: #534
While I was at it, I also fixed a couple of typos in the doc strings (
serailized/serialized).