Conversation
|
I should probably have opened this as Draft while I work on fixing the test. |
|
I have 9 out of 24 test failing even on master on my machine saying the snapshot are too different. |
|
I have only 6 test failing, all with less than 0.07 variance on Github Action. |
|
@afshinm Just let me know if you see anything visual regression I could fix, otherwise this PR is ready. |
|
Sounds good, thanks @mrleblanc101. Will have a look. |
|
@afshinm @mrleblanc101 Hey guys. I just wanted to point out, - this PR also fixes a related bug, wherein the anchor/button element had its https://github.com/usablica/intro.js/blob/v6.0.0/src/core/showElement.js#L79 The bug is a problem because it poses a critical Web Accessibility error. |
Fix #1752