Fix: check MutuallyExclusiveFlags across parent command chain#2274
Open
siutsin wants to merge 1 commit intourfave:mainfrom
Open
Fix: check MutuallyExclusiveFlags across parent command chain#2274siutsin wants to merge 1 commit intourfave:mainfrom
siutsin wants to merge 1 commit intourfave:mainfrom
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Follow-up to PR #2266. That PR fixed persistent flag propagation for
MutuallyExclusiveFlags, but the exclusivity validation itself was not updated. The check only looked at the current command's groups, so parent group violations were silently ignored on subcommands.This PR walks the parent chain when validating, matching how persistent flag inheritance already works in
parseFlags.Which issue(s) this PR fixes:
Fixes #2273
Testing
Added tests covering propagation, violation detection on subcommands and grandchild commands, and mixed parent/subcommand exclusive groups.
Release Notes