fix: Wrong scale digit number if currency NumberDataFormatter ends with "_)"#336
Open
imckl wants to merge 2 commits intounvell:masterfrom
Open
fix: Wrong scale digit number if currency NumberDataFormatter ends with "_)"#336imckl wants to merge 2 commits intounvell:masterfrom
imckl wants to merge 2 commits intounvell:masterfrom
Conversation
update: Add test case for the fix - ExcelInTest.cs, A03.xlsx
|
Though less commonly, you might also have more than one _* in sequence. |
datadiode
added a commit
to datadiode/ReoGrid
that referenced
this pull request
Dec 30, 2020
…s (unvell/ReoGrid PR unvell#367) / _* in number formats lead to wrong number of fractional digits (unvell/ReoGrid PR unvell#336)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
A commonly used currency format defined as
[$USD] #,##0.0000_);([$USD] #,##0.0000)in Excel, was wrongly parsed with two more scale digit (eg: from1.1234to1.123400)From common currency selection:
Notes:
Test case:
Preview:
Raw value:
[$USD] #,##0.0000_);([$USD] #,##0.0000)2.749576904167612118.391509433962266-8.7510561342592581-7.6259722222222228ReoGrid with fix:
ReoGrid without fix:
Excel behaviors (noticed that the values is lined up at the decimal point):
Reference: