ngfw-15757 remediation of cybersecurity findings#1189
Open
DhirajM09 wants to merge 1 commit into
Open
Conversation
DhirajM09
requested review from
AristaKB,
ShubhamJambhale-arista,
VarshaKache,
mayur-dhande and
singhrohit23
AristaKB
approved these changes
May 12, 2026
Contributor
|
@DhirajM09 shouldn't this be part of 17.5 release ? |
mayur-dhande
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
uvm/hier/usr/lib/python3/dist-packages/uvm/login_tools.py#documentation comment with anXXXX...placeholder. The comment shows the format of the per-appliance TOTP URI file; documentation intent is preserved.i18ntools/translate.pyprocess_google()function (already 100% commented out internally; contained the rotated-and-verified-dead Google Translate API key) and its caller inmain(). Thexxpseudo-locale path is unchanged; non-xxlanguages now load and save the PO file unchanged, which matches what the no-op function did before..arista/secret_allowlist.yamlFALSE_POSITIVEentries withcategoryandreasonfields, matching the existing schema.