jscript: Split JSX out of the JavaScript parser#4379
Open
b4n wants to merge 1 commit intouniversal-ctags:masterfrom
Open
jscript: Split JSX out of the JavaScript parser#4379b4n wants to merge 1 commit intouniversal-ctags:masterfrom
b4n wants to merge 1 commit intouniversal-ctags:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4379 +/- ##
=======================================
Coverage 85.91% 85.91%
=======================================
Files 252 252
Lines 62683 62713 +30
=======================================
+ Hits 53854 53882 +28
- Misses 8829 8831 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JSX doesn't support XML comments, and their presence can prevent further parsing of JS code embedded in HTML, which is more relaxed about them. Fix this by separating the JSX from the regular JavaScript parser, as JSX is a JavaScript extension that is not meant to be standardized to JavaScript anyway. Fixes universal-ctags#4373.
b4n
force-pushed
the
jscript-jsx-split
branch
from
5943d0b to
27017db
Compare
Member
|
Thank you. |
jafl
approved these changes
Feb 7, 2026
Contributor
|
@masatake What is your opinion? Should we merge this? |
Member
|
Splitting the parser is good. Parsers should not share kinds, roles, fields, extras, and properties tables. See the last 4 commits in https://github.com/masatake/ctags/commits/jscript-jsx-split-dont-share-lang-model/ Could you cherry pick masatake@c8b3f99 ? Could you squash masatake@5cedc18 and masatake@76cf595 into your commit? Of course, you can change the words in the NEWS file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JSX doesn't support XML comments, and their presence can prevent further parsing of JS code embedded in HTML, which is more relaxed about them.
Fix this by separating the JSX from the regular JavaScript parser, as JSX is a JavaScript extension that is not meant to be standardized to JavaScript anyway.
Fixes #4373.