Skip to content

html: Do not parse comments in JSX mode#4378

Open
b4n wants to merge 1 commit intouniversal-ctags:masterfrom
b4n:jscript-jsx-no-comment
Open

html: Do not parse comments in JSX mode#4378
b4n wants to merge 1 commit intouniversal-ctags:masterfrom
b4n:jscript-jsx-no-comment

Conversation

@b4n
Copy link
Member

@b4n b4n commented Feb 4, 2026

JSX doesn't support XML comments, and their presence can prevent further parsing of JS code.

Fixes #4373.

JSX doesn't support XML comments, and their presence can prevent
further parsing of JS code.

Fixes universal-ctags#4373.
@codecov
Copy link

codecov bot commented Feb 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.90%. Comparing base (2046889) to head (f2e6cc0).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4378   +/-   ##
=======================================
  Coverage   85.90%   85.90%           
=======================================
  Files         252      252           
  Lines       62670    62671    +1     
=======================================
+ Hits        53835    53836    +1     
  Misses       8835     8835           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JavaScript in HTML: fails to parse after an HTML commen since JSX support

2 participants