Open
Conversation
@ntrel reviewed the case in universal-ctags#2241. Thank you.
Close universal-ctags#2241. @mastake's note: This pull chnage is based on universal-ctags#2241 submitted by @ntrel. I adjust the change not to fill "signature" field for tags of "type" kind. I also adjust the change to avoid regression.
Codecov Report
@@ Coverage Diff @@
## master #3212 +/- ##
=======================================
Coverage 84.94% 84.95%
=======================================
Files 206 206
Lines 49030 49044 +14
=======================================
+ Hits 41650 41665 +15
+ Misses 7380 7379 -1
Continue to review full report at Codecov.
|
masatake
commented
Dec 2, 2021
| { | ||
| if (tail ("type")) /* check for type declaration */ | ||
| { | ||
| found_tag = false; |
Member
Author
There was a problem hiding this comment.
These lines are not covered by the test cases.
Member
Author
|
If more than two types are defined under the https://www.gnu-pascal.de/gpc/Type-Declaration.html |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is mostly based on #2241 submitted by @ntrel.
I adjusted the changes to fit the latest codebase.