Taskbar Widget - Song Info toggle#696
Draft
radioactive-exe wants to merge 1 commit intounchihugo:masterfrom
Draft
Taskbar Widget - Song Info toggle#696radioactive-exe wants to merge 1 commit intounchihugo:masterfrom
radioactive-exe wants to merge 1 commit intounchihugo:masterfrom
Conversation
* Add toggle to show/hide Artist Info * Option added to the Taskbar Widget options * Added to the UI updating flow * `en-US` localisation updated
Author
|
Switch to a draft as I have a couple more points I'd like to tackle with regards to the taskbar widget |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added the ability to toggle artist info in the taskbar widget, akin to the taskbar control setting.
Motivation
This goal originally came from personal experience, using Windhawk with a narrower taskbar or also playing songs with longer names. I realised that the amount of space the widget could take could not really be anticipated, and would thus sometimes end up covering half my taskbar. This led me to realise that the ability to have a small widget with just the icon with or without the controls - aka a constant size - would be a nice, sleek addendum. Never developed or contributed to a .NET/Windows App, but took me about 20 minutes to get the reins, so sorry if it seems rusty/primitive!
Type of Change
What Changed
en-USlocalisation (I will add more in languages I know when/if we confirm the next steps or whether this will be dropped)Additional Information
Another method I considered implementing was consolidating the media controls and song info toggles into one "Taskbar widget display" (or similarly named) drop-down, with options like "Full (Song Info and Controls)", "Concise (Icon and Controls only)", etc.
However, I felt like this addition of a toggle was a simple solution. Which do you think would be a more appropriate implementation given your vision for FF?
Also, tackling the same size point, I also wonder if adding a "constant/max-size" option for when song info is shown would be a good target to implement next - let me know!
Checklist