wip: use CircleMarker instead of Circle icon#2061
Draft
yohanboniface wants to merge 1 commit intomasterfrom
Draft
wip: use CircleMarker instead of Circle icon#2061yohanboniface wants to merge 1 commit intomasterfrom
yohanboniface wants to merge 1 commit intomasterfrom
Conversation
This needs more work, but would allow:
- better performance:
- one svg for all features instead of one HTML per feature
- as it inherits from path, only visible feature are added to DOM
- controling the circle radius, which is something requested from time
to time
To move forward, we need:
- [ ] to have default per UI class (instead of in the SCHEMA), as
for example we do not want the same default weight for a line or
for the CircleMarker
- [ ] maybe to have some static properties, so to keep the circle
border color always white, as now (but can be discussed)
- [ ] when editing a feature, to show properties according to the
current selected UI class, so user can define the radius when
"Circle" is selected, but also other path related properties
(fillColor, opacity…)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This needs more work, but would allow:
To move forward, we need: