reuse original ApplicationEnvironmentPreparedEvent#421
Merged
ulisesbocchio merged 1 commit intoulisesbocchio:masterfrom Jan 25, 2026
Merged
reuse original ApplicationEnvironmentPreparedEvent#421ulisesbocchio merged 1 commit intoulisesbocchio:masterfrom
ulisesbocchio merged 1 commit intoulisesbocchio:masterfrom
Conversation
Owner
|
thanks! that's pretty clever, reusing the same event rather than creating a new one. |
ArloL
force-pushed
the
spring-boot-4-compatibility
branch
from
edd679d to
aec5f86
Compare
Contributor
Author
|
Glad you like the solution 😊 I just rebased and force-pushed. Hope everything works. |
Owner
|
sorry @ArloL , would you mind rebasing one more time? I made a boo boo on the previous change, that's why the pipeline failed. |
ArloL
force-pushed
the
spring-boot-4-compatibility
branch
from
aec5f86 to
12f6df7
Compare
Contributor
Author
|
Sure. Done 👌 |
Contributor
Author
|
Any blockers remaining? |
Owner
|
Merged, thank you @ArloL ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tries to fix #417 by reusing the original ApplicationEnvironmentPreparedEvent; I am really not sure if this breaks anything else. This works around the binary incompatibility issue of the constructor where the package has moved. Please let me know if I can improve the code in any way to make it mergeable. I could successfully run
mvn clean verifywith openjdk 17.