Remove unnecessary ternary expression in whois lookup#175
Open
vcokltfre wants to merge 1 commit intouetchy:masterfrom
Open
Remove unnecessary ternary expression in whois lookup#175vcokltfre wants to merge 1 commit intouetchy:masterfrom
vcokltfre wants to merge 1 commit intouetchy:masterfrom
Conversation
TAG-Epic
approved these changes
Nov 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This minor PR cleans a ternary expression into a simple comparison for improved clarity, as it's easier to understand what logic is being followed this way, rather than having to try and work out a ternary in your head, and also because the result of the comparison is already a boolean value it makes sense to use that value directly.