Skip to content

Comments

Templates: Next 16#4688

Merged
zbeyens merged 3 commits intomainfrom
next-16
Oct 15, 2025
Merged

Templates: Next 16#4688
zbeyens merged 3 commits intomainfrom
next-16

Conversation

@zbeyens
Copy link
Member

@zbeyens zbeyens commented Oct 15, 2025

Checklist

  • yarn typecheck
  • yarn lint:fix
  • yarn test
  • yarn brl
  • yarn changeset
  • ui changelog

@codesandbox
Copy link

codesandbox bot commented Oct 15, 2025

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@changeset-bot
Copy link

changeset-bot bot commented Oct 15, 2025

⚠️ No Changeset found

Latest commit: abdac3c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 15, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
plate Building Building Preview Comment Oct 15, 2025 11:57am

@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Oct 15, 2025
@claude
Copy link
Contributor

claude bot commented Oct 15, 2025

Claude finished @zbeyens's task —— View job


Code Review for PR #4688: Templates: Next 16

I've completed my review of the Next.js 16 upgrade for the template projects. Here's my comprehensive feedback:

Review Tasks

  • Review Next.js configuration migration
  • Check package.json dependency updates
  • Assess removal of development tooling files
  • Verify TypeScript configuration changes
  • Review lock file updates
  • Check for breaking changes
  • Verify changeset requirement

🟡 Review Summary

Good Changes:

  • ✅ Clean migration from next.config.mjs to next.config.ts with proper TypeScript types
  • ✅ Appropriate addition of React Compiler (reactCompiler: true) for performance optimization
  • ✅ Consistent Turbopack configuration across templates
  • ✅ Dependencies properly updated to support React 19.2.0 and Next.js 16.0.0-beta.0
  • ✅ TypeScript configuration properly includes Next.js plugin

🚨 Issues to Address

1. Missing Changeset (Required)

The changeset bot correctly identified that no changeset is included. Since this PR updates template packages, a changeset is needed:

yarn changeset add

Select the affected packages (plate-template and plate-playground-template) and mark as minor/patch version bump.

2. Missing Changelog Update

Per the requirements, updates affecting templates should be documented in docs/components/changelog.mdx. Please add an entry documenting the Next.js 16 upgrade for templates.

3. Potential Breaking Changes

The main app (apps/www) has the entire webpack configuration commented out, which previously handled:

  • External modules for shiki and typescript
  • Browser polyfills for Node.js modules (crypto, stream)
  • Process environment setup

Question: Are these webpack configurations no longer needed with Next.js 16, or should they be migrated to the new configuration format?

4. Development Tooling Removal

Large amount of development tooling files were removed from plate-template:

  • .claude/ directory (13 files)
  • .cursor/ directory (5 files)
  • .taskmaster/ directory (7 files)
  • CLAUDE.md file

Recommendation: If these files were intentionally removed to simplify the template, this is fine. However, if they provide value for users starting new projects, consider keeping them.

📋 Specific Observations

  1. React Compiler Configuration:

    • Templates use reactCompiler: true (always enabled)
    • Main app uses conditional: process.env.RC === 'true' || process.env.NODE_ENV === 'production'
    • Consider aligning this behavior or documenting why they differ
  2. TypeScript Version: Updated to 5.9.2 (not the latest 5.8.3 mentioned in tech stack docs)

  3. ESLint Beta: Using eslint-config-next@16.0.0-beta.0 - ensure this is stable enough for template users

  4. Turbopack Note: Good practice adding the comment "Not needed in your project" for the turbopack root config

✅ Verified Items

  • Security: No security issues identified in the changes
  • Error Handling: No error handling code modified
  • Coding Standards: Changes follow project conventions
  • Dependencies: All Plate packages remain at their current versions (no unintended updates)
  • pnpm Overrides: Properly configured for React 19 compatibility

🔧 Action Items

  1. Required: Add changeset for the template package updates
  2. Required: Update docs/components/changelog.mdx with Next.js 16 template upgrade
  3. Clarify: Confirm if webpack config removal in main app is intentional
  4. Consider: Document why React Compiler config differs between templates and main app

Once these items are addressed, this PR will be ready to merge. The core migration appears solid and follows Next.js 16 best practices.


@zbeyens zbeyens merged commit 6b50852 into main Oct 15, 2025
6 of 7 checks passed
@zbeyens zbeyens deleted the next-16 branch October 15, 2025 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL This PR changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant