feat: accept fontFamily parameter in createYaruTheme#1075
Draft
adil192 wants to merge 5 commits intoubuntu:mainfrom
Draft
feat: accept fontFamily parameter in createYaruTheme#1075adil192 wants to merge 5 commits intoubuntu:mainfrom
adil192 wants to merge 5 commits intoubuntu:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds font parameters to
createYaruTheme,createYaruLightTheme, andcreateYaruDarkTheme.When the theme is created, its text theme is passed around to several
___ThemeDataclasses, making it difficult to completely override the font later.Adding the parameters right at the start fixes this issue.
This has no impact on YaruVariant.
I had to workaround this recently in saber-notes/saber@a453147. Note that changing the font isn't purely aesthetic, but is sometimes needed for language support.
Builds upon #1074. I'll mark this as a draft until that PR is merged.