Conversation
Unifies the AppInfoBar into a single widget that constructs itself, instead of app packages providing widgets manually. This also unifies some shared metadata on each package type's data object.
I'd like to add this back later as an actual shared page structure, but at the moment this was only used on 1 page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unifies the
AppInfoBarinto a single widget that constructs itself, instead of app packages providing widgets manually.This also unifies some shared metadata and notions of confinement on each package type's data object so that the info bar can be constructed centrally.
The pages themselves should almost look the exact same. The only "big" difference is wording tweaks for contact links. Local debs will display "Developer website" instead of the URL of the link for those pages, and publisher links will always say "Contact [publisher]" when possible.
In the future, additional metadata will be surfaced for debs and additional wording tweaks, as defined in our designs.
This change will pave the way for more unified set of widgets for each package type instead of having them all be defined individually.
UDENG-8947