Remove redundant subclass method annotations#917
Open
brianhelba wants to merge 2 commits intotypeddjango:masterfrom
Open
Remove redundant subclass method annotations#917brianhelba wants to merge 2 commits intotypeddjango:masterfrom
brianhelba wants to merge 2 commits intotypeddjango:masterfrom
Conversation
These methods will be inherited from the parent class unchanged.
Contributor
Author
|
@intgr PTAL. |
There was a problem hiding this comment.
Pull request overview
This pull request removes redundant method type annotations from subclasses in Django REST Framework stubs. When a subclass doesn't override a method's implementation, the type annotation is automatically inherited from the parent class, making explicit re-declaration unnecessary. Additionally, the PR improves type specificity in BasePagination.get_schema_fields by changing its return type from list[Any] to list[CoreAPIField].
Changes:
- Removed redundant
__new__and__class_getitem__annotations fromBaseSerializerthat are inherited fromField - Removed unused
typing_extensions.Selfimport from serializers.pyi - Improved type specificity of
BasePagination.get_schema_fieldsreturn type fromlist[Any]tolist[CoreAPIField] - Removed redundant
paginate_queryset,get_paginated_response_schema, andget_schema_fieldsmethod annotations from pagination subclasses
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| rest_framework-stubs/serializers.pyi | Removed redundant __new__ and __class_getitem__ methods from BaseSerializer and the now-unused Self import |
| rest_framework-stubs/pagination.pyi | Improved BasePagination.get_schema_fields return type specificity and removed redundant method annotations from PageNumberPagination, LimitOffsetPagination, and CursorPagination subclasses |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These methods will be inherited from the parent class unchanged.