Speculative fix for CI test failure: write atomically (and always clean)#862
Closed
wti wants to merge 1 commit intotwostraws:mainfrom
Closed
Speculative fix for CI test failure: write atomically (and always clean)#862wti wants to merge 1 commit intotwostraws:mainfrom
wti wants to merge 1 commit intotwostraws:mainfrom
Conversation
This fix is a guess; I'm unable to replicate the failure locally. - Error is `The file “story-with-invalid-lastModified.md” doesn’t exist` - I assume this is b/c check happens before the file-write is visible. (Although even non-atomic write should result in existing file?) Also use defer to always clean (avoid false positive from prior file)
Contributor
Author
|
Urk! Well, that didn't work... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For CI test failure reported in #858 and #861
This fix is a guess; I'm unable to replicate the failure locally.
The file “story-with-invalid-lastModified.md” doesn’t existAlso use defer to always clean (avoid false positive from prior file)